getenv() error with UNIX micropython

[Nico]

Hi,

I would like to make HBMQTT work with micropython. I've cloned micropython repo (head revision) and built UNIX successfully.
Before being able to run, I need to install some dependencies like logging. Therefore, I run the following command :

Code: Select all

./micropython -v -m upip install logging

Unfortunatelly, it gives the following error:

Code: Select all

./micropython -v -m upip install logging
Traceback (most recent call last):
  File "", line 291, in <module>
  File "", line 252, in main
TypeError: function takes 1 positional arguments but 2 were given

I guess it comes from upip 0.6 which is frozen in micropython. Looking at upip.py source code shows that line 252 is :

Code: Select all

 install_path = os.getenv("MICROPYPATH", DEFAULT_MICROPYPATH)
 

Recents modification make on import on this module could cause this error.... So I decided to try fo fix this. I:
- cloned micropython-lib
- changed install_path = os.getenv("MICROPYPATH", DEFAULT_MICROPYPATH) to install_path = os.getenv("MICROPYPATH") or DEFAULT_MICROPYPATH
- run python setup.py sdist (with CPython3)
- copied micropython-upip-0.6.tar.gz to micropython/tools
- make clean all on unix/
then run again upip gives now :

Code: Select all

./micropython -v -m upip install logging
Segmentation fault: 11

Can you tell if I'm right with the origin of this error (wrong getenv() being called) ? If so, how can I go further with this segmentation fault ?

[pfalcon]

Thanks, both issues are indeed artifacts of considerable recent refactoring, and now should be fixed in master. It's better to report bugs to https://github.com/micropython/micropython/issues though.

[Nico]

Thanks for your reply. I could have created a pull request but I missed the change in unix/modos.c, which I guess was causing the seg fault.