Page 1 of 1
Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE
Posted: Tue Jun 28, 2016 3:49 am
by shaoziyang
Why micropython in Nucleo-F401RE/F411RE not using PB8/PB9 instead of PB6/PB7 as I2C1 pin? As PB8/PB9 is D14/D15 in Arduino, it will be more compatible with arduino.
Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE
Posted: Tue Jun 28, 2016 4:10 am
by dhylands
That seems reasonable to me. I'd recommend changing the NUCLEO_F411RE board as well.
Are you comfortable doing a pull request? If not, I can go ahead and put one together.
Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE
Posted: Tue Jun 28, 2016 7:10 am
by shaoziyang
dhylands wrote:That seems reasonable to me. I'd recommend changing the NUCLEO_F411RE board as well.
Are you comfortable doing a pull request? If not, I can go ahead and put one together.
How to do a pull request? I am a newie of github. I have also add support of Nucleo_L476RG and Nucleo_F746ZG board.
Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE
Posted: Tue Jun 28, 2016 2:44 pm
by shaoziyang
dhylands wrote:That seems reasonable to me. I'd recommend changing the NUCLEO_F411RE board as well.
Are you comfortable doing a pull request? If not, I can go ahead and put one together.
It seem that need permission to pull request. I try to pull request, but get error message below.
I put files in attachments.
Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE
Posted: Tue Jun 28, 2016 3:27 pm
by dhylands
THat's correct. There are only 2 people who have write permissions to the micrpython repository (and I'm not one).
The workflow for doing pull requests is described here:
https://help.github.com/articles/using-pull-requests/
- make a fork (on github.com)
- add your fork as a remote to your local repository
- make a branch on your local repository
- make changes on the branch
- push the changes to your fork (you will have write permission for this)
- create a pull request (on github.com)
Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE
Posted: Wed Jun 29, 2016 3:44 am
by shaoziyang
dhylands wrote:THat's correct. There are only 2 people who have write permissions to the micrpython repository (and I'm not one).
The workflow for doing pull requests is described here:
https://help.github.com/articles/using-pull-requests/
- make a fork (on github.com)
- add your fork as a remote to your local repository
- make a branch on your local repository
- make changes on the branch
- push the changes to your fork (you will have write permission for this)
- create a pull request (on github.com)
Thank you.