Page 2 of 2

Re: new port pull request

Posted: Sat Jan 09, 2021 4:29 pm
by stijn
ExXec wrote:
Fri Jan 08, 2021 3:13 pm
If there is someone who will keep it updated, be it me or someone else, is there another condition for an inclusion into the main repo?
I don't know actually, this isn't really described anywhere. But I think the main conditions are:
- the platfrom isn't super outdated and commonly available and expected to remain so for like a decade (just a wild guess, but I assume we don't want a port for a platform which the manufacturer will stop producing next year or so)
- multiple people can work on it / fix it when needed i.e. have the toolchain and whatever required
- there is enough interest from others i.e. people actually using it
- bonus if it it can be built by the Continuous Integration so it can be verified it at least compiles

Again, this is just what I assume. If you want to get input from the maintainer(s), just create a PR I'd say (after having read CONTRIBUTING.md etc so it's in the correct shape)

Re: new port pull request

Posted: Sun Jan 10, 2021 12:58 pm
by ExXec
Alright, thank you!

Re: new port pull request

Posted: Wed Jan 13, 2021 9:27 am
by ExXec
Do you have any documentation on your continuos integration?
How would I implement that?

Re: new port pull request

Posted: Wed Jan 13, 2021 9:34 am
by stijn
See tools/ci.sh: for each port it defines how to build it (almost from scratch). For most microcontroller ports that means downloading the toolchain first, then building. In .github/workflows there's a YAML file calling the corresponding function which results in builds done on each push by Github, see Actions tab in web interface https://github.com/micropython/micropython/actions

Re: new port pull request

Posted: Wed Jan 13, 2021 7:22 pm
by ExXec
I see, thanks.

Also, in the license header, do I put my name or Damien P. George?

Re: new port pull request

Posted: Wed Jan 13, 2021 8:24 pm
by stijn
Don't know what the policy is on that, I always just copy one with Damien's name :)

Re: new port pull request

Posted: Thu Jan 14, 2021 10:09 am
by ExXec
alright

by any chance, do you know where I could find a changelog of the oofatfs lib and how to adjust to the change?

I am preparing my branch for the PR and rebasing to the latest version, but I get an error during compilation:
viewtopic.php?f=15&t=9563

Re: new port pull request

Posted: Thu Jan 14, 2021 11:28 am
by stijn
Run git log -- lib/oofatfs/* ?