Doc pull request failed

C programming, build, interpreter/VM.
Target audience: MicroPython Developers.
Post Reply
hlovatt
Posts: 68
Joined: Thu Aug 15, 2019 3:52 am
Location: Sydney

Doc pull request failed

Post by hlovatt » Thu Jul 02, 2020 3:35 am

Hi,

Tried to update the documentation for the `pyb.SPI` class, but it failed: https://github.com/micropython/micropyt ... /154777451.

I edited the file in Github and issued the request from Github.

User avatar
pythoncoder
Posts: 5956
Joined: Fri Jul 18, 2014 8:01 am
Location: UK
Contact:

Re: Doc pull request failed

Post by pythoncoder » Thu Jul 02, 2020 4:59 am

I'm not sure what your query is. The quick way to do minor doc changes is as you found, to edit the file on GitHub and issue a PR.

For more complex changes, or code changes that you need to test locally, ensure you have a fork of the source tree. Clone your fork to your PC. Create a branch and check it out. Do your changes and push the branch to GitHub. On GitHub go to your fork, change to the branch, and issue the PR.
Peter Hinch
Index to my micropython libraries.

User avatar
jimmo
Posts: 2754
Joined: Tue Aug 08, 2017 1:57 am
Location: Sydney, Australia
Contact:

Re: Doc pull request failed

Post by jimmo » Thu Jul 02, 2020 6:38 am

hlovatt wrote:
Thu Jul 02, 2020 3:35 am
Tried to update the documentation for the `pyb.SPI` class, but it failed: https://github.com/micropython/micropyt ... /154777451.
The github actions UI is kind of confusing. If you click on the "x build" subheading on the left hand side, then expand the "build docs" heading, it shows the full log of generating the documentation.

In this case the error is:

Code: Select all

/home/runner/work/micropython/micropython/docs/library/pyb.SPI.rst:67: WARNING: Inline literal start-string without end-string.
This is because ``ti` should be ``ti``

hlovatt
Posts: 68
Joined: Thu Aug 15, 2019 3:52 am
Location: Sydney

Re: Doc pull request failed

Post by hlovatt » Thu Jul 02, 2020 11:40 pm

Thanks will do the pull request again.

Post Reply