Doc change pull requests languishing

C programming, build, interpreter/VM.
Target audience: MicroPython Developers.
Post Reply

stijn
Posts: 568
Joined: Thu Apr 24, 2014 9:13 am

Re: Doc change pull requests languishing

Post by stijn » Fri Oct 09, 2020 7:40 am

In general I think these contributions are worth it. However (left a github comment as well) none of the commit messages adhere to the coding standards, only the Pull requests titles do. So I'd suggest you change that: if it cannot be merged as-is, it's more than twice the work for the maintainer. And that's likely the main reason these aren't merged: lack of time. Also perhaps create one single commit where you fix typos instead of x commits where only one word changes.

hlovatt
Posts: 59
Joined: Thu Aug 15, 2019 3:52 am
Location: Sydney

Re: Doc change pull requests languishing

Post by hlovatt » Fri Oct 09, 2020 10:00 pm


stijn
Posts: 568
Joined: Thu Apr 24, 2014 9:13 am

Re: Doc change pull requests languishing

Post by stijn » Sat Oct 10, 2020 11:57 am

hlovatt wrote:
Fri Oct 09, 2020 10:00 pm
I'm editing directly on GitHub and it doesn't seem to have that ability.
Ah that's too bad. Might be less work to work locally from a fork then push.

User avatar
deshipu
Posts: 1385
Joined: Thu May 28, 2015 5:54 pm

Re: Doc change pull requests languishing

Post by deshipu » Sun Oct 11, 2020 7:39 am

I don't think anybody is going to look at them as long as they are failing the tests.

Post Reply