MicroPython Forum (Archive)

Hi Core Team,

I have a number of minor Doc change pull requests:

https://github.com/micropython/micropython/pull/6387
https://github.com/micropython/micropython/pull/6386
https://github.com/micropython/micropython/pull/6352
https://github.com/micropython/micropython/pull/6351
https://github.com/micropython/micropython/pull/6349
https://github.com/micropython/micropython/pull/6309
https://github.com/micropython/micropython/pull/6308

All submitted in August.

Are you still wanting minor contributions like this?

Cheers,

-- Howard.

In general I think these contributions are worth it. However (left a github comment as well) none of the commit messages adhere to the coding standards, only the Pull requests titles do. So I'd suggest you change that: if it cannot be merged as-is, it's more than twice the work for the maintainer. And that's likely the main reason these aren't merged: lack of time. Also perhaps create one single commit where you fix typos instead of x commits where only one word changes.

OK I have closed all the old requests and resubmitted new ones:

https://github.com/micropython/micropython/pull/6528
https://github.com/micropython/micropython/pull/6529
https://github.com/micropython/micropython/pull/6531
https://github.com/micropython/micropython/pull/6532
https://github.com/micropython/micropython/pull/6534
https://github.com/micropython/micropython/pull/6535
https://github.com/micropython/micropython/pull/6536

Had to close old and resubmit new because couldn't edit commit message. I'm editing directly on GitHub and it doesn't seem to have that ability.

hlovatt wrote: ↑

Fri Oct 09, 2020 10:00 pm

I'm editing directly on GitHub and it doesn't seem to have that ability.

Ah that's too bad. Might be less work to work locally from a fork then push.

I don't think anybody is going to look at them as long as they are failing the tests.