Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE

Discussion and questions about boards that can run MicroPython but don't have a dedicated forum.
Target audience: Everyone interested in running MicroPython on other hardware.
Post Reply
shaoziyang
Posts: 319
Joined: Sun Apr 17, 2016 1:55 pm

Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE

Post by shaoziyang » Tue Jun 28, 2016 3:49 am

Why micropython in Nucleo-F401RE/F411RE not using PB8/PB9 instead of PB6/PB7 as I2C1 pin? As PB8/PB9 is D14/D15 in Arduino, it will be more compatible with arduino.

Image

User avatar
dhylands
Posts: 3356
Joined: Mon Jan 06, 2014 6:08 pm
Location: Peachland, BC, Canada
Contact:

Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE

Post by dhylands » Tue Jun 28, 2016 4:10 am

That seems reasonable to me. I'd recommend changing the NUCLEO_F411RE board as well.

Are you comfortable doing a pull request? If not, I can go ahead and put one together.

shaoziyang
Posts: 319
Joined: Sun Apr 17, 2016 1:55 pm

Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE

Post by shaoziyang » Tue Jun 28, 2016 7:10 am

dhylands wrote:That seems reasonable to me. I'd recommend changing the NUCLEO_F411RE board as well.

Are you comfortable doing a pull request? If not, I can go ahead and put one together.
How to do a pull request? I am a newie of github. I have also add support of Nucleo_L476RG and Nucleo_F746ZG board.

shaoziyang
Posts: 319
Joined: Sun Apr 17, 2016 1:55 pm

Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE

Post by shaoziyang » Tue Jun 28, 2016 2:44 pm

dhylands wrote:That seems reasonable to me. I'd recommend changing the NUCLEO_F411RE board as well.

Are you comfortable doing a pull request? If not, I can go ahead and put one together.
It seem that need permission to pull request. I try to pull request, but get error message below.
git -c diff.mnemonicprefix=false -c core.quotepath=false push -v --tags --set-upstream origin master:master
remote: Permission to micropython/micropython.git denied to shaoziyang.
fatal: unable to access 'https://github.com/micropython/micropython.git/': The requested URL returned error: 403


Pushing to https://github.com/micropython/micropython.git

Completed with errors, see above.
I put files in attachments.
boards.zip
(22.63 KiB) Downloaded 133 times

User avatar
dhylands
Posts: 3356
Joined: Mon Jan 06, 2014 6:08 pm
Location: Peachland, BC, Canada
Contact:

Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE

Post by dhylands » Tue Jun 28, 2016 3:27 pm

THat's correct. There are only 2 people who have write permissions to the micrpython repository (and I'm not one).

The workflow for doing pull requests is described here: https://help.github.com/articles/using-pull-requests/

- make a fork (on github.com)
- add your fork as a remote to your local repository
- make a branch on your local repository
- make changes on the branch
- push the changes to your fork (you will have write permission for this)
- create a pull request (on github.com)

shaoziyang
Posts: 319
Joined: Sun Apr 17, 2016 1:55 pm

Re: Suggest using PB8/PB9 pin as I2C1 in Nucleo-F401RE

Post by shaoziyang » Wed Jun 29, 2016 3:44 am

dhylands wrote:THat's correct. There are only 2 people who have write permissions to the micrpython repository (and I'm not one).

The workflow for doing pull requests is described here: https://help.github.com/articles/using-pull-requests/

- make a fork (on github.com)
- add your fork as a remote to your local repository
- make a branch on your local repository
- make changes on the branch
- push the changes to your fork (you will have write permission for this)
- create a pull request (on github.com)
Thank you. :)

Post Reply