Just to be clear -- this is just my suggestion as someone who spends a moderate amount of time spelunking in the core (but without any actual authority or ability to accept changes).
implementing properties in user modules
Re: implementing properties in user modules
Re: implementing properties in user modules
Re: implementing properties in user modules
For future reference: without losing sight of your comment, I have created a pull request with the necessary changes: https://github.com/micropython/micropython/pull/5648
And you were right, lifting code verbatim from circuitpython's runtime.c fixes the issue.
Re: implementing properties in user modules
Re: implementing properties in user modules
Talking about https://github.com/stinos/micropython-w ... per.h#L372 bascially. With 'we' I meant 'me and colleagues' but actually I wrote all of it so on second thought: yes would be less confusing to just say 'I'
Re: implementing properties in user modules
Sorry, I wasn't nit-picking, I was simply curious. This wrapper project of yours is really interesting.stijn wrote: ↑Sat Feb 15, 2020 8:08 pmTalking about https://github.com/stinos/micropython-w ... per.h#L372 bascially. With 'we' I meant 'me and colleagues' but actually I wrote all of it so on second thought: yes would be less confusing to just say 'I'
Re: implementing properties in user modules
Oh no problem I didn't treat it as nit-picking, I genuinely think saying 'we' is confusing because it doesn't convey any meaning to others.
Thanks! It didn't completely turn out the way I wanted but if you have to wrap hundreds of functions/classes it's quite the timesaverThis wrapper project of yours is really interesting.