loboris MicroPython_ESP32_psRAM_LoBo fork

All ESP32 boards running MicroPython.
Target audience: MicroPython users with an ESP32 board.
Post Reply
jedie
Posts: 232
Joined: Fri Jan 29, 2016 12:32 pm
Contact:

loboris MicroPython_ESP32_psRAM_LoBo fork

Post by jedie » Thu Jan 16, 2020 9:33 am

It seems loboris MicroPython_ESP32_psRAM_LoBo fork is currently unmaintained, see: https://github.com/loboris/MicroPython_ ... issues/302

There exists a ticket for porting stuff into mainline micropython: https://github.com/loboris/MicroPython_ ... issues/304

I think there are some things that can be transferred. Some drivers for example.
e.g.:

Code: Select all

static const char* const display_types[] = {
    "ILI9341",
    "ILI9488",
    "ST7789V",
    "ST7735",
    "ST7735R",
    "ST7735B",
    "M5STACK",
    "Unknown",
};

static const char* const touch_types[] = {
    "None",
    "xpt2046",
    "stmpe610",
    "Unknown",
};
Unfortunately I can't help much because I don't have enough C knowledge.

What do you think?


Capstan
Posts: 113
Joined: Sun Jan 29, 2017 4:03 pm
Location: Texas, USA

Re: loboris MicroPython_ESP32_psRAM_LoBo fork

Post by Capstan » Thu Jan 16, 2020 4:32 pm

"hard to know if such code was/wasn't influenced by GPL code", that's silly. You could say that about any code anywhere. I think it's just a weak excuse for NIH.

User avatar
mattyt
Posts: 264
Joined: Mon Jan 23, 2017 6:39 am

Re: loboris MicroPython_ESP32_psRAM_LoBo fork

Post by mattyt » Thu Jan 16, 2020 11:47 pm

Capstan wrote:
Thu Jan 16, 2020 4:32 pm
"hard to know if such code was/wasn't influenced by GPL code", that's silly. You could say that about any code anywhere. I think it's just a weak excuse for NIH.
At the time this was a very legitimate concern. Loboris had claimed his repo was covered under the MIT license yet there were clear uses of GPL, violating the MIT claim.

Since he removed the GPL code this is probably now usable. There is a worry that it could be argued that viral nature of the GPL means that the whole repository became GPL at the point where he included any GPL code but I think this is specious. I believe that he had just not performed due diligence in checking licenses and inadvertently included it - removing it seems satisfactory to me. But IANAL.

As far as I'm aware the port of any Lobo features would be considered. However, as covered in other posts, it's not trivial as Lobo was able to take some liberties since his fork was only for ESP32. Further, while many people have requested Lobo features, few (none?) have stepped forward to submit PR's.

I have been trying to extract some features, most recently RMT, but found that it was easier to re-think the design and re-implement. It wasn't NIH, it was simply that the design I had in mind was very different to that found in the Lobo codebase.

Anyway, I just thought a little historical context might be worthwhile sharing... :)

Capstan
Posts: 113
Joined: Sun Jan 29, 2017 4:03 pm
Location: Texas, USA

Re: loboris MicroPython_ESP32_psRAM_LoBo fork

Post by Capstan » Fri Jan 17, 2020 3:38 pm

Loboris apparently went through his code and cleaned out what little GPL there was back in 2018. But the remark by dpgeorge about it was made on Jul 25, 2019 so it looks like he still considers the repository tainted. Seems unjustified to me.

User avatar
pythoncoder
Posts: 3856
Joined: Fri Jul 18, 2014 8:01 am
Location: UK
Contact:

Re: loboris MicroPython_ESP32_psRAM_LoBo fork

Post by pythoncoder » Sat Jan 18, 2020 6:26 am

The point here is that MicroPython is used in commercial products, as are the products of George Robotics, so the legal issue is important. If you've followed discussions in the industry on the GPL, the received wisdom is that even if a developer has seen GPL code before writing his own version, his solution (and hence the entire codebase) could be challenged. Strict "clean room" conditions are required when re-implementing GPL code. The question is whether the Loboris port adopted this precaution.

The GPL is widely viewed as toxic to commercial enterprises, so extreme caution is advised.

IANAL but I do read a lot ;)
Peter Hinch

Post Reply